1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • exec/lbshell.js xtrn_sec.js src/sbbs3/xtrn_sec.cpp

    From Rob Swindell@VERT to Git commit to sbbs/master on Tue Nov 3 22:07:59 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/255ffd7abcf16aad5b561fef
    Modified Files:
    exec/lbshell.js xtrn_sec.js src/sbbs3/xtrn_sec.cpp
    Log Message:
    Move the external program "pause on exit" implementation back to the C++ code.

    Originally, the "pause on exit" was implemented in the C++ version of sbbs_t::xtrn_sec() and not sbbs_t::exec_xtrn(). This meant that the pause option was only implemented when the prgoram was invoked from the menu and
    not when invoked directly (e.g. via Baja or JS exec_xtrn function).

    When sbbs_t::xtrn_sec() was ported to JS, that functionality was also moved
    to JS. But it really should have been implemented in exec_xtrn() to begin
    with so that regardless of how the program is invoked, that SCFG setting takes effect.

    Thanks to Michael Long for pointing this out.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net