1. Forum
  2. DOVE-Net
  3. Synchronet JavaScript

  • Archive.extract() with max_files parameter

    From Nightfox to Digital Man on Tue Aug 2 09:29:51 2022
    Hi DM,

    Today I was using the Archive class to extract exactly one file from a zip file, and I'm a little confused on the exception throwing behavior regarding the max_files parameter. When calling extract(), I gave it a filename pattern and expected exactly 1 file to be extracted, so I also gave a max_files argument as 1. It extracted the one file, but it threw an exception with the error "Error: maximum number of files (1) extracted (after extracting 1 item successfully)".

    Should that be an error condition to throw an exception? I expected 1 file to be extracted, and that file was extracted successfully. If I specify max_files as 2, then it doesn't throw an exception.

    Nightfox
  • From Digital Man@VERT to Nightfox on Tue Aug 2 17:20:45 2022
    Re: Archive.extract() with max_files parameter
    By: Nightfox to Digital Man on Tue Aug 02 2022 09:29 am

    Hi DM,

    Today I was using the Archive class to extract exactly one file from a zip file, and I'm a little confused on the exception throwing behavior regarding the max_files parameter. When calling extract(), I gave it a filename pattern and expected exactly 1 file to be extracted, so I also gave a max_files argument as 1. It extracted the one file, but it threw an exception with the error "Error: maximum number of files (1) extracted (after extracting 1 item successfully)".

    Should that be an error condition to throw an exception? I expected 1 file to be extracted, and that file was extracted successfully. If I specify max_files as 2, then it doesn't throw an exception.

    I can see how that would be surprising behavior. I just committed a change. Let me know how that works for you.
    --
    digital man (rob)

    Breaking Bad quote #22:
    I got one more shot at that little skid mark. - Hank Schrader
    Norco, CA WX: 87.3°F, 35.0% humidity, 12 mph SSE wind, 0.00 inches rain/24hrs ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Nightfox to Digital Man on Wed Aug 3 09:00:23 2022
    Re: Archive.extract() with max_files parameter
    By: Digital Man to Nightfox on Tue Aug 02 2022 05:20 pm

    a filename pattern and expected exactly 1 file to be extracted, so I
    also gave a max_files argument as 1. It extracted the one file, but
    it threw an exception with the error "Error: maximum number of files
    (1) extracted (after extracting 1 item successfully)".

    I can see how that would be surprising behavior. I just committed a change. Let me know how that works for you.

    I've updated, and now it doesn't throw an exception for this case. Thanks.

    Nightfox